-
Notifications
You must be signed in to change notification settings - Fork 3
fix: external PostgreSQL & Redis configurations #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f3c9490
a44c719
6ab5584
a48e8b5
de25ff2
e244a1d
08bca54
1ce8fa4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,9 +2,9 @@ apiVersion: v1 | |
| entries: | ||
| phase: | ||
| - apiVersion: v2 | ||
| created: "2025-09-27T18:45:20.618693+05:30" | ||
| created: "2025-11-15T15:37:02.493652+05:30" | ||
| description: A Helm chart for deploying the Phase Secrets Manager | ||
| digest: cdd437fc2cce88e078da782dd69b18eb2ddc22fe380df1ca72c767f550cecd6d | ||
| digest: 962f1d473b222c05fc8ade650b0f54bb2dddff8da335564f02bdf503ed2dee58 | ||
| home: https://github.com/phasehq/kubernetes-secrets-operator | ||
| icon: https://phase.dev/apple-touch-icon.png | ||
| keywords: | ||
|
|
@@ -18,50 +18,12 @@ entries: | |
| - https://github.com/phasehq/console | ||
| type: application | ||
| urls: | ||
| - https://helm.phase.dev/phase-0.4.2.tgz | ||
| version: 0.4.2 | ||
| - apiVersion: v2 | ||
| created: "2025-09-27T18:45:20.618273+05:30" | ||
| description: A Helm chart for deploying the Phase Secrets Manager | ||
| digest: 45321c29e26c00c8c052cc5cfeeca7b383caa0958fa97415ed81e3d2817c011b | ||
| home: https://github.com/phasehq/kubernetes-secrets-operator | ||
| icon: https://phase.dev/apple-touch-icon.png | ||
| keywords: | ||
| - phase | ||
| - deployment | ||
| maintainers: | ||
| - email: [email protected] | ||
| name: Nimish | ||
| name: phase | ||
| sources: | ||
| - https://github.com/phasehq/console | ||
| type: application | ||
| urls: | ||
| - https://helm.phase.dev/phase-0.4.1.tgz | ||
| version: 0.4.1 | ||
| - apiVersion: v2 | ||
| created: "2025-09-24T20:12:36.640449+05:30" | ||
| description: A Helm chart for deploying the Phase Secrets Manager | ||
| digest: e7c0c633fe75fef2c20c4499e740cf6c940e0437c0b30101e09930f58d54a8a9 | ||
| home: https://github.com/phasehq/kubernetes-secrets-operator | ||
| icon: https://phase.dev/apple-touch-icon.png | ||
| keywords: | ||
| - phase | ||
| - deployment | ||
| maintainers: | ||
| - email: [email protected] | ||
| name: Nimish | ||
| name: phase | ||
| sources: | ||
| - https://github.com/phasehq/console | ||
| type: application | ||
| urls: | ||
| - phase-0.4.0.tgz | ||
| version: 0.4.0 | ||
| - phase-0.5.0.tgz | ||
| version: 0.5.0 | ||
| phase-kubernetes-operator: | ||
| - apiVersion: v2 | ||
| appVersion: 1.3.0 | ||
| created: "2025-09-27T18:45:20.619088+05:30" | ||
| created: "2025-11-15T15:37:02.494035+05:30" | ||
| description: A Helm chart for deploying the Phase Kubernetes Operator | ||
| digest: ac562ccaea71b4ae9bdefeeef9b3660f092b998d673ca96f7f557d05aff93895 | ||
| home: https://github.com/phasehq/kubernetes-secrets-operator | ||
|
|
@@ -79,6 +41,6 @@ entries: | |
| - https://github.com/phasehq/kubernetes-secrets-operator | ||
| type: application | ||
| urls: | ||
| - https://helm.phase.dev/phase-kubernetes-operator-1.3.0.tgz | ||
| - phase-kubernetes-operator-1.3.0.tgz | ||
| version: 1.3.0 | ||
| generated: "2025-09-27T18:45:20.617165+05:30" | ||
| generated: "2025-11-15T15:37:02.492839+05:30" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,13 @@ metadata: | |
| {{- include "phase.labels" . | nindent 4 }} | ||
| job-name: {{ include "phase.fullname" . }}-migrations | ||
| annotations: | ||
| # Migrations are run after all other resources (including PostgreSQL and Redis) are created and ready | ||
| {{- if or .Values.global.external.enabled .Values.database.external .Values.redis.external }} | ||
| # Migrations hook behavior: | ||
| # - If `database.external = true`, the database is managed outside this chart and is | ||
| # expected to exist already, so we run migrations as a *pre-install* hook and fail fast | ||
| # before rolling out the rest of the stack. | ||
| # - If `database.external = false`, this chart creates the Postgres Deployment/PVC and | ||
| # must wait for them to be ready, so we run migrations as a *post-install* hook. | ||
| {{- if .Values.database.external }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Migration Hook Timing Needs Redis AwarenessThe migrations job runs as a pre-install hook when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the job migration depend on both the database and Redis being available ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Additional suggestion from simulation.
|
||
| "helm.sh/hook": "pre-install,pre-upgrade" | ||
| {{- else }} | ||
| "helm.sh/hook": "post-install,post-upgrade" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually do not understand why do we have this as a pre-install hook?
was there any reason for this design?