Skip to content

Conversation

@neonstalwart
Copy link
Member

this is critical for any existing installations of pintura - particularly if they are using continuous deployment.

https://www.npmjs.org/package/websocket-server

This package has been unpublished.

Description A WebSocket Server for node.js, 90-100% spec compatible.
Unpublished By miksago
Unpublished On Wed Sep 24 2014 12:00:42 GMT+0000 (UTC)

it looks like it might not be too much work to change to socket.io so i'm going to take a crack at it and hope to have something by the end of today. @kriszyp let me know asap if you'd rather use another lib or if you've already worked up something previously that's ready to use.

working on replacing it with socket.io
@neonstalwart neonstalwart force-pushed the ws branch 2 times, most recently from dece301 to 2f69f5e Compare September 24, 2014 21:54
websocket-server is unpublished so updating to an alternative
@neonstalwart
Copy link
Member Author

  • merge update to work with ws instead of websocket-server jsgi-node#9
  • publish new jsgi-node to npm
  • update this package.json to point to new jsgi-node
  • apply these same changes to the master branch of pintura
  • publish new version of pintura to npm (based on master branch, so anyone currently using pintura can update with minimal impact)
  • update persevere-example-wiki to use this version of pintura as a minimum (?)

@neonstalwart
Copy link
Member Author

i forgot to mention... i ended up using https://github.com/einaros/ws rather than socket.io or engine.io because they seemed to be a little too opinionated by default.

@kriszyp
Copy link
Member

kriszyp commented Sep 24, 2014

Sounds good, I'll take a look.

@kriszyp kriszyp merged commit b877156 into persvr:dev-2.0 Sep 29, 2014
@neonstalwart neonstalwart deleted the ws branch September 29, 2014 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants