[FEATURE] Table: Add link editor to the table column setting #506
Conversation
Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Mahmoud Shahrokni <[email protected]>
shahrokni
force-pushed
the
feat/add_table_link_editor
branch
from
a636307 to
1b49437
Compare
Nexucis
requested review from
a team and
jgbernalp
and removed request for
a team
| <Dialog.Header>Data link</Dialog.Header> | ||
| <Dialog.Content> | ||
| <LinkEditorForm | ||
| mode="modalEmbedded" |
There was a problem hiding this comment.
As discussed on past PRs for the same topic, please make it an inline editor here too rather than a modal.
There was a problem hiding this comment.
We discussed this and the conclusion was that there is no enough space to have it inline under the column setting.
That was the reason we decided to come up with the mode in the first place.
Am I missing something?
Just asking to remember what the final conclusion was.
There was a problem hiding this comment.
I think I missed a discussion then, I was still on this opinion perses/perses#3653 (comment);
The panel editor is already a (big) modal so I'm personally still in favor of the inline display. There's (currently) not much horizontal space available but quite some room to expand vertically, enough for lengthy links I'd say (and we can think about a max height + either scroll or expand on focus)
But let's see what the others think - it looks like you were at least 2 in favor of the modal display then?
AntoineThebaud
left a comment
AntoineThebaud
left a comment
There was a problem hiding this comment.
Still more in favor of having the new Link form inline rather than in a modal, but I'm fine with the MVP in this state.
After a developing a quick prototype, we decided to go with the inline option.
|
Relates to: perses/perses#3483
Description 🖊️
This change adds a link editor to the table column setting editor.
Test 🧪
You should be able to add, edit, apply and finally persist the link setting.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes