Skip to content

PG-2372 - Remove ENABLE_TDE flag (18)#981

Merged
Andriciuc merged 3 commits into
18from
update-docker-pg_tde-install(18)
May 18, 2026
Merged

PG-2372 - Remove ENABLE_TDE flag (18)#981
Andriciuc merged 3 commits into
18from
update-docker-pg_tde-install(18)

Conversation

@Andriciuc
Copy link
Copy Markdown
Contributor

This PR updates the docker installation step to remove the ENABLE TDE option.

This PR updates the docker installation step to remove the ENABLE TDE option.
@Andriciuc Andriciuc temporarily deployed to update-docker-pg_tde-install(18) - postgresql-docs-preview-18 PR #981 May 18, 2026 08:34 — with Render Destroyed
@Andriciuc Andriciuc requested a review from shahidullah79 May 18, 2026 11:28
Copy link
Copy Markdown

@shahidullah79 shahidullah79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested command in the doc is incorrect.

docker run --name container-name -e POSTGRES_PASSWORD=sUpers3cRet -c 'shared_preload_libraries=pg_tde' -d percona/percona-distribution-postgresql:{{dockertag}}
It should be

docker run --name container-name -e POSTGRES_PASSWORD=sUpers3cRet -d percona/percona-distribution-postgresql:{{dockertag}} -c 'shared_preload_libraries=pg_tde'

Reason:
The docker run command interprets the -c flag as --cpu-shares (which expects an integer), rather than passing it down as a configuration parameter to PostgreSQL.

To pass configuration flags directly to the underlying PostgreSQL engine in a Docker container, you need to append them to the very end of your command string, after the image name.
In a docker run statement, everything specified before the image name (percona/percona-distribution-postgresql:18.4) belongs to the Docker CLI engine. Everything specified after the image name is treated as an argument override passed directly to the container's entrypoint script (in this case, postgres).

By shifting -c shared_preload_libraries=pg_tde to the end, Docker stops trying to parse it as a CPU limitation flag and safely hand-delivers it to PostgreSQL at boot.

Copy link
Copy Markdown

@shahidullah79 shahidullah79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andriciuc Andriciuc merged commit 7d3f3c9 into 18 May 18, 2026
1 check passed
@Andriciuc Andriciuc deleted the update-docker-pg_tde-install(18) branch May 18, 2026 12:27
Andriciuc added a commit that referenced this pull request May 18, 2026
This PR is a backport of this issue #981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants