This repository was archived by the owner on Mar 31, 2026. It is now read-only.
PMM-11699 Reviewed and updated the advisor checks for PostgreSQL#82
Open
nastena1606 wants to merge 2 commits into
Open
PMM-11699 Reviewed and updated the advisor checks for PostgreSQL#82nastena1606 wants to merge 2 commits into
nastena1606 wants to merge 2 commits into
Conversation
|
Your Render PR Server URL is https://portal-doc-pr-82.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cg9em1rhp8u303tp2lt0. |
elchinoo
reviewed
Mar 16, 2023
|
|
||
| ## Description | ||
| When this parameter is enabled (which it is by default), the PostgreSQL server tries to make sures that updates are physically written to disk, by issuing fsync() system calls or various equivalent methods mentioned in wal_sync_method. | ||
| By default, `fsync` is enabled in PostgreSQL so that the PostgreSQL server tries to make sure that updates are physically written to disk by issuing `fsync()` system calls or various equivalent methods mentioned in `wal_sync_method`. |
There was a problem hiding this comment.
Wouldn't be better to simplify with something like:
Fsync` is enabled by default in PostgreSQL ...
elchinoo
reviewed
Mar 16, 2023
| Turning off `fsync` can slightly improve performance with the risk of unrecoverable data corruption in case of a power failure or system crash. | ||
|
|
||
| Turning off fsync can slightly improve performance with the risk of unrecoverable data corruption in case of a power failure or system crash. | ||
| Therefore, it is only advisable to turn off `fsync` if you can easily recreate your entire database from external data. |
There was a problem hiding this comment.
I would rephrase here to emphasize even more that it isn't advisable, for example:
It's not advisable to turn off fsync unless the database can be easily recreated from an external data source.
elchinoo
reviewed
Mar 16, 2023
| From the PostgreSQL log we should be able to get insight about the failure, we can even try the command manually to verify the result. | ||
|
|
||
| Something to keep in mind is the archive command will be executed under the ownership of the same user that the PostgreSQL server is running as, so the paths, tools, scripts, etc., that are called or acceded from the archive command should be accessible for the user running the service (usually postgres). | ||
| Something to keep in mind is that the same user that runs the PostgreSQL server (usually postgres), will execute the archive command, so the paths, tools, scripts, etc., that are called or acceded from the archive command should be accessible for the user running the service. |
There was a problem hiding this comment.
I'm not sure if "acceded" would be the best wording here. I couldn't easily understand what it intends to say in this context. We may simplify a bit? We should remember that many no-native speakers will use this documentation, and using simpler daily vocabulary is a must.
catalinaadam
approved these changes
Mar 17, 2023
|
|
||
| ## Description | ||
| When this parameter is enabled (which it is by default), the PostgreSQL server tries to make sures that updates are physically written to disk, by issuing fsync() system calls or various equivalent methods mentioned in wal_sync_method. | ||
| By default, `fsync` is enabled in PostgreSQL so that the PostgreSQL server tries to make sure that updates are physically written to disk by issuing `fsync()` system calls or various equivalent methods mentioned in `wal_sync_method`. |
Contributor
There was a problem hiding this comment.
Suggested change
| By default, `fsync` is enabled in PostgreSQL so that the PostgreSQL server tries to make sure that updates are physically written to disk by issuing `fsync()` system calls or various equivalent methods mentioned in `wal_sync_method`. | |
| By default, `fsync` is enabled in PostgreSQL. This enables the PostgreSQL server to ensure that updates are physically written to disk. This is done by issuing `fsync()` system calls or various equivalent methods mentioned in the `wal_sync_method`. |
| When this parameter is enabled (which it is by default), the PostgreSQL server tries to make sures that updates are physically written to disk, by issuing fsync() system calls or various equivalent methods mentioned in wal_sync_method. | ||
| By default, `fsync` is enabled in PostgreSQL so that the PostgreSQL server tries to make sure that updates are physically written to disk by issuing `fsync()` system calls or various equivalent methods mentioned in `wal_sync_method`. | ||
|
|
||
| Turning off `fsync` can slightly improve performance with the risk of unrecoverable data corruption in case of a power failure or system crash. |
Contributor
There was a problem hiding this comment.
Suggested change
| Turning off `fsync` can slightly improve performance with the risk of unrecoverable data corruption in case of a power failure or system crash. | |
| Turning off `fsync` can slightly improve performance. However, this comes with the risk of unrecoverable data corruption in the case of a power failure or system crash. |
| ``` | ||
| if members_number < 3: | ||
| ``` | ||
| This advisor returns a warning if the replica set has less than 3 members. |
Contributor
There was a problem hiding this comment.
Suggested change
| This advisor returns a warning if the replica set has less than 3 members. | |
| This advisor check warns if the replica set has less than three members. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.