Skip to content

Pt mongodb stalk#1126

Open
palazuelosagustin wants to merge 4 commits into
3.xfrom
pt-mongodb-stalk
Open

Pt mongodb stalk#1126
palazuelosagustin wants to merge 4 commits into
3.xfrom
pt-mongodb-stalk

Conversation

@palazuelosagustin
Copy link
Copy Markdown
Collaborator

@palazuelosagustin palazuelosagustin commented May 12, 2026

  • The contributed code is licensed under GPL v2.0
  • Contributor Licence Agreement (CLA) is signed
  • util/update-modules has been ran
  • Documentation updated
  • Test suite update

@it-percona-cla
Copy link
Copy Markdown

it-percona-cla commented May 12, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Collaborator

@svetasmirnova svetasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Please follow the rules:

  • Documentation for Bash tools should be placed inline. Check other tools like pt-mysql-summary or pt-stalk. There should not be a separate README file for Bash tools.
  • Sign contributor agreement
  • Create a regression test for your changes, see examples in the t/TOOLNAME directories

Please also consider if this change fits existing pt-stalk, as a new option.

@palazuelosagustin
Copy link
Copy Markdown
Collaborator Author

Changes made:

  - Removed bin/pt-mongodb-stalk.README.
  - Moved the useful README content into inline POD inside bin/pt-mongodb-stalk.
  - Added regression test: t/pt-mongodb-stalk/pt-mongodb-stalk.t.
  - Test uses fake MongoDB/OS commands, so it does not require a real MongoDB instance.
  - Test covers --no-stalk, expected output files, currentOp allUsers:true, and retained non-empty mongotop.err.
  
  On the pt-stalk question: I’d argue this is better as a separate tool for now. pt-stalk is tightly MySQL-specific around mysql, mysqladmin, SHOW GLOBAL STATUS, SHOW PROCESSLIST, and MySQL option passthrough.
  Folding MongoDB in would require a larger abstraction of connection handling, triggers, and collectors rather than a simple option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants