Skip to content

K8SPG-876: Log commands before execing them in containers #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

K8SPG-876: Log commands before execing them in containers #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f430b9a
K8SPG-876: Log commands before execing them in containers
egegunes Oct 29, 2025
58b89cd
Merge branch 'main' into K8SPG-876
egegunes Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/controller/runtime/pod_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"k8s.io/client-go/tools/remotecommand"
"k8s.io/client-go/util/flowcontrol"
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
logf "sigs.k8s.io/controller-runtime/pkg/log"
)

// podExecutor runs command on container in pod in namespace. Non-nil streams
Expand Down Expand Up @@ -62,6 +63,8 @@ func NewPodExecutor(config *rest.Config) (podExecutor, error) {

exec, err := remotecommand.NewSPDYExecutor(configCopy, "POST", request.URL())

log := logf.FromContext(ctx)
log.V(1).Info("Running command in pod", "pod", pod, "container", container, "command", command)
if err == nil {
err = exec.StreamWithContext(ctx, remotecommand.StreamOptions{
Stdin: stdin,
Expand Down
4 changes: 4 additions & 0 deletions percona/clientcmd/clientcmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"k8s.io/client-go/tools/remotecommand"
"k8s.io/client-go/util/flowcontrol"
"k8s.io/client-go/util/retry"
logf "sigs.k8s.io/controller-runtime/pkg/log"
)

type Client struct {
Expand Down Expand Up @@ -73,6 +74,9 @@ func (c *Client) Exec(ctx context.Context, pod *corev1.Pod, containerName string
return errors.Wrap(err, "failed to create executor")
}

log := logf.FromContext(ctx)
log.V(1).Info("Running command in pod", "pod", pod.Name, "container", containerName, "command", command)

retryErr := retry.OnError(retry.DefaultRetry, func(err error) bool {
return true // Retry on all errors
}, func() error {
Expand Down
Loading