SEP-2024: Validate failure_reason against task-history status

[Copilot]

POST /history/ accepted failure reasons for statuses that do not carry operator-facing failure details, allowing contradictory task-history records.

• Validation

  • Reject non-null failure_reason when status.operator_summary() returns None.
  • Return a structured 422 response naming both conflicting fields.
  • Preserve existing behavior for FAILED, LOST, STALE, and UNLAUNCHABLE.

• Coverage

  • Cover SUCCESS, PENDING, RUNNING, and STOPPED rejection.
  • Retain coverage for accepted failure statuses and reason normalization.

• API contract

  • Update the Tasks OpenAPI specification and changelog fragment.

[Copilot]

🟢 Approval recommended

The implementation matches the stated API contract and includes appropriate coverage and documentation.

Pull request overview

Adds task-history validation to prevent contradictory failure reasons.

Changes:

• Rejects failure reasons for statuses without operator summaries.
• Adds rejection coverage and structured 422 assertions.
• Updates OpenAPI documentation and changelog.

File summaries

File	Description
app/tasks/routes.py	Adds status/reason validation.
tests/app/tasks/test_routes.py	Tests rejected status combinations.
frontend/packages/api/specs/tasks.json	Documents the new 422 response.
changelog.d/SEP-2024.changed.md	Records the behavior change.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
app/core/db
utils.py
app/inventory/migrations
env.py
app/sep/migrations
env.py
app/tasks
routes.py
app/tasks/migrations
env.py
Project Total

This report was generated by python-coverage-comment-action