Skip to content

fix(deps): update js-yaml to 4.3.2 - #1511

Merged
yyyyyyyan merged 3 commits into
mainfrom
copilot/fix-js-yaml-vulnerability
Sep 12, 2026
Merged

yyyyyyyan merged 3 commits into
mainfrom
copilot/fix-js-yaml-vulnerability

Conversation

Copilot AI commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

js-yaml 4.3.1 is vulnerable to excessive CPU consumption when processing repeated empty merge sources. This updates the transitive dependency to the lowest patched release.

  • Dependency update

    • Expand the pnpm override to cover vulnerable 4.x releases through 4.3.1.
    • Regenerate pnpm-lock.yaml with js-yaml 4.3.2.
  • Reachability assessment — high confidence

    • Not reachable in SEP runtime.
    • js-yaml is only introduced through the development-time openapi-typescript → @redocly/openapi-core chain.
    • SEP code generation consumes JSON specifications or FastAPI JSON endpoints; no direct use of the affected loader APIs or configuration was found.
    • The update primarily clears the vulnerability alert and hardens development tooling.
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>js-yaml: maxTotalMergeKeys does not limit CPU use for empty merge sources</alert_title>
<alert_description>## Summary

maxTotalMergeKeys does not count empty mappings. An attacker can repeatedly merge a large sequence of them and consume significant CPU without reaching the configured limit.

Example

arr: &arr [{}, {}, {}, ...] # N empty mappings
targets:
  - <<: *arr                # repeated K times

For every target, the loader iterates all N elements of arr. This results in O(N * K) work while totalMergeKeys remains unchanged.

PoC

import { performance } from 'node:perf_hooks'
import { load, YAML11_SCHEMA } from 'js-yaml'

const n = 20000

const src =
  'arr: &arr [' + '{},'.repeat(n).slice(0, -1) + ']\n' +
  'targets:\n' +
  '  - <<: *arr\n'.repeat(n)

const started = performance.now()

load(src, { schema: YAML11_SCHEMA })

console.log(`${(performance.now() - started).toFixed(1)} ms`)

Observed results:

N YAML size Time
800 ~13 KB ~20 ms
3200 ~50 KB ~180 ms
20000 ~500 KB ~13 s

Impact

An attacker can submit a relatively small YAML document that causes prolonged CPU consumption despite the default maxTotalMergeKeys limit.

Fix

Count each merge-source mapping as one budget unit, in addition to counting its keys.

Difference with v5

In v3 & v4, merge is enabled by default. So, the severity score is higher.</alert_description>

high
GHSA-2883-xcg3-v3hh, CVE-2026-84375
js-yaml
npm
<vulnerable_versions>4.3.1</vulnerable_versions>
<patched_version>4.3.2</patched_version>
<manifest_path>frontend/pnpm-lock.yaml</manifest_path>

https://github.com/nodeca/js-yaml/security/advisories/GHSA-2883-xcg3-v3hh https://nvd.nist.gov/vuln/detail/CVE-2026-84375 https://github.com/nodeca/js-yaml/pull/797 https://github.com/nodeca/js-yaml/commit/3485bc06ff8a0251505f44a00414d90df2466639 https://github.com/nodeca/js-yaml/commit/6a8e05f9a485188ed730ac81e81ae221352ef480 https://github.com/nodeca/js-yaml/commit/d90b6612a5a84385bdcb556c44578eac76dc0f6b https://github.com/nodeca/js-yaml/releases/tag/3.15.2 https://github.com/nodeca/js-yaml/releases/tag/4.3.2 https://github.com/advisories/GHSA-2883-xcg3-v3hh

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known brea...

Co-authored-by: yyyyyyyan <24644216+yyyyyyyan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix js-yaml vulnerability alert for CPU usage fix(deps): update js-yaml to 4.3.2 Sep 12, 2026
Copilot AI requested a review from yyyyyyyan September 12, 2026 00:28
@yyyyyyyan
yyyyyyyan requested a balanced review from Copilot September 12, 2026 00:36
@yyyyyyyan yyyyyyyan added qa not required Merge without a QA sign-off: substitutes for 'qa passed' in label-gate. Does not skip any test job. dependencies labels Sep 12, 2026
@yyyyyyyan
yyyyyyyan marked this pull request as ready for review September 12, 2026 00:36
@yyyyyyyan
yyyyyyyan requested a review from maxbube as a code owner September 12, 2026 00:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused override and lockfile updates consistently resolve the vulnerable transitive dependency.

Pull request overview

Updates the development-only js-yaml dependency to the lowest patched release, resolving the reported CPU-consumption vulnerability.

Changes:

  • Expands the override through vulnerable version 4.3.1.
  • Regenerates the lockfile with js-yaml 4.3.2.
File summaries
File Description
frontend/pnpm-workspace.yaml Pins affected 4.x versions to 4.3.2.
frontend/pnpm-lock.yaml Records the patched resolution and dependency snapshot.
Review details

Files not reviewed (1)

  • frontend/pnpm-lock.yaml: Generated file
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yyyyyyyan
yyyyyyyan merged commit b8bd655 into main Sep 12, 2026
15 checks passed
@yyyyyyyan
yyyyyyyan deleted the copilot/fix-js-yaml-vulnerability branch September 12, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies frontend qa not required Merge without a QA sign-off: substitutes for 'qa passed' in label-gate. Does not skip any test job.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants