Skip to content

Add support for viewing and refunding transactions - #768

Draft
aviupadhyayula wants to merge 5 commits into
ticketing-v2from
add-refunds
Draft

aviupadhyayula wants to merge 5 commits into
ticketing-v2from
add-refunds

Conversation

@aviupadhyayula

@aviupadhyayula aviupadhyayula commented Jan 18, 2025

Copy link
Copy Markdown
Member

Creates new viewset, serializer, and permission class to interact with transaction records. Superusers can see all transaction records. Non-privileged users must specify an event, and can only view transactions for that event if they're appropriately privileged.

Also contains minor modifications to attributes in TicketTransactionRecord.

TODO: still need to integrate with Cybersource's API for refunds.

Closes #756.

@aviupadhyayula
aviupadhyayula changed the base branch from master to ticketing-v2 January 18, 2025 16:43
@aviupadhyayula aviupadhyayula linked an issue Jan 18, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Jan 18, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.00000% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.68%. Comparing base (80bb21d) to head (52ca5c4).

Files with missing lines Patch % Lines
backend/clubs/permissions.py 24.00% 19 Missing ⚠️
backend/clubs/views.py 32.00% 17 Missing ⚠️
backend/clubs/models.py 33.33% 12 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           ticketing-v2     #768      +/-   ##
================================================
- Coverage         72.08%   71.68%   -0.40%     
================================================
  Files                32       32              
  Lines              6996     7068      +72     
================================================
+ Hits               5043     5067      +24     
- Misses             1953     2001      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aviupadhyayula
aviupadhyayula marked this pull request as draft January 18, 2025 17:00
@rohangpta

rohangpta commented Feb 17, 2025

Copy link
Copy Markdown
Member

Seems very valuable - is this a blocker to launch?

@aviupadhyayula

aviupadhyayula commented Feb 17, 2025

Copy link
Copy Markdown
Member Author

OSA's expressed concern about the payments side of things in our conversations -- this isn't a blocker, but it's something that we want to have in place before our pilot. If we have to refund something, doing it through the Cybersource dashboard makes our internal accounting tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for refunding transactions

2 participants