implemented NetwellResponse - #7
Open
Smarties89 wants to merge 2 commits into
Open
Conversation
Author
|
Implementing response as a method instead of a simple wrapper created far reaching backward incompatibilities. Every custom check would stop working. Therefore I hope you came to the same resolution and also thought it would be a good idea to implement it as a simple wrapper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented
NetwellResponse, that makes it simpler to assert contains, contains not etc.(This is in response to #6 )
I implemented
URl('...').responseas a method as we discussed.But I realised that it breaks backward compatibility (you can't use
URL('...').responseanymore.Should I change it to be a simple property like before but with the included contains, ... methods?
PS.
To make life easier for you I included the script I tested it with: