Skip to content

Conversation

@brenard
Copy link
Contributor

@brenard brenard commented Feb 13, 2023

Fix #9

@CloCkWeRX CloCkWeRX requested a review from hbeni February 14, 2023 12:25
@cweiske
Copy link
Member

cweiske commented Aug 10, 2023

Please add a unit test that shows that this bug existed.

@Neustradamus

This comment was marked as off-topic.

@brenard
Copy link
Contributor Author

brenard commented Oct 13, 2023

@brenard: Have you seen the @cweiske comment?

Yes, I seen. The problem is, like exposed in the issue, this bug occurred only in not common case : I discovered it when using the constraint overlay with a constraint on an attribute used as some objects RDN. To make a test case that demonstrated this bug, I have to change the OpenLDAP server used during tests, but it's an external server, not controlled by the test process. How I can do that ?

If you look my patch, you will see I just verify the $modifications array is not empty before trying to apply these modifications. I don't think there is a situation in which this could be a problem, it's just avoid an empty modification request to the LDAP server. By fixing this issue, I also just remove a useless request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Net_LDAP2_Entry::update(): do not submit empty modification

3 participants