fix(plugins): Ensure IPC data is correctly passed to renderer plugins #4048
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,4 +1,5 @@ | |||
| import is from 'electron-is'; | |||
| import { IpcRendererEvent } from 'electron'; | |||
There was a problem hiding this comment.
'IpcRendererEvent' is defined but never used.
Co-authored-by: Daksh777 <[email protected]>
…zation Add Hindi & Bengali romanization support for synced lyrics
Co-authored-by: Daksh777 <[email protected]>
Upgrade youtubei.js to 16.0.1 and fix downloader plugin
| const video = document.querySelector<HTMLVideoElement>('video'); | ||
| if (!video) return; | ||
|
|
||
| const adContainer = document.querySelector('.ytp-ad-player-overlay, .video-ads, .ytp-ad-module'); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace '.ytp-ad-player-overlay,·.video-ads,·.ytp-ad-module' with ⏎····'.ytp-ad-player-overlay,·.video-ads,·.ytp-ad-module',⏎··
| const adContainer = document.querySelector('.ytp-ad-player-overlay, .video-ads, .ytp-ad-module'); | |
| const adContainer = document.querySelector( | |
| '.ytp-ad-player-overlay, .video-ads, .ytp-ad-module', | |
| ); |
|
|
||
| const adContainer = document.querySelector('.ytp-ad-player-overlay, .video-ads, .ytp-ad-module'); | ||
| const adText = document.querySelector('.ytp-ad-text, .ytp-ad-preview-text'); | ||
|
|
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
| const adText = document.querySelector('.ytp-ad-text, .ytp-ad-preview-text'); | ||
|
|
||
| // Check if ad is playing | ||
| const isAd = adContainer || adText || |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·adContainer·||·adText·||· with ⏎····adContainer·||⏎····adText·||
| const isAd = adContainer || adText || | |
| const isAd = | |
| adContainer || | |
| adText || |
|
|
||
| // Check if ad is playing | ||
| const isAd = adContainer || adText || | ||
| document.querySelector('.ad-showing') || |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ···········
| document.querySelector('.ad-showing') || | |
| document.querySelector('.ad-showing') || |
| // Check if ad is playing | ||
| const isAd = adContainer || adText || | ||
| document.querySelector('.ad-showing') || | ||
| document.querySelector('.advertisement'); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ···········
| document.querySelector('.advertisement'); | |
| document.querySelector('.advertisement'); |
|
|
||
| // Try to click skip button if available | ||
| const skipButton = document.querySelector<HTMLElement>( | ||
| '.ytp-ad-skip-button, .ytp-ad-skip-button-modern, button.ytp-ad-skip-button' |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
| '.ytp-ad-skip-button, .ytp-ad-skip-button-modern, button.ytp-ad-skip-button' | |
| '.ytp-ad-skip-button, .ytp-ad-skip-button-modern, button.ytp-ad-skip-button', |
| blocker = await ElectronBlocker.fromLists( | ||
| fetch, | ||
| blockLists, | ||
| { |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎··········fetch,⏎··········blockLists,⏎········· with fetch,·blockLists,
| blocker = await ElectronBlocker.fromLists( | |
| fetch, | |
| blockLists, | |
| { | |
| blocker = await ElectronBlocker.fromLists(fetch, blockLists, { |
| fetch, | ||
| blockLists, | ||
| { | ||
| enableCompression: true, |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
| enableCompression: true, | |
| enableCompression: true, |
| }, | ||
| ); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ··},⏎········ with }
| }, | |
| ); | |
| }); |
| } | ||
| }, | ||
|
|
||
| async onConfigChange(newConfig: AdBlockerPluginConfig) { |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/require-await> reported by reviewdog 🐶
Async method 'onConfigChange' has no 'await' expression.
Added SimpMusic Lyrics provider to fetch and display lyrics for supported tracks from the SimpMusic Lyrics API. This improves lyrics coverage, especially for non-English songs. Co-authored-by: Daksh777 <[email protected]>
Co-authored-by: Daksh777 <[email protected]>
…ider Add SimpMusic Lyrics provider integration
| @@ -0,0 +1,138 @@ | |||
| import { jaroWinkler } from '@skyra/jaro-winkler'; | |||
|
|
|||
| import { config } from '../renderer/renderer'; | |||
There was a problem hiding this comment.
'config' is defined but never used.
…n toggle Co-authored-by: Daksh777 <[email protected]>
…n-css Replace video toggle dual-button with single eye icon toggle
1 participant
This PR fixes a bug that was preventing the SponsorBlock plugin from working (#4046)
The problem was in our custom IPC wrapper for renderer plugins. It was accidentally stripping out the event object from incoming messages, which caused the actual data (like the skip segments for SponsorBlock) to get mixed up.
I've adjusted the wrapper to make sure it passes along all the arguments correctly. This gets SponsorBlock working again and makes our plugin system a bit more reliable for the future.