Conversation
jbigot
left a comment
There was a problem hiding this comment.
Can you also add Kitware to the copyright at the top of the root CMakeLists.txt you contributed to
|
Thank you so much for the contribution @francois-kitware ! From our point of view, it's basically good to go as-is, if you maintain the plugin separately in a submodule. We just need to add a Changelog entry, and some other minor elements related to our "checkboxes". Would you also be interested in the review of the plugin code? In this case, this should be done on your gitlab since from github we only have a submodule reference. |
d9b3078 to
98655ea
Compare
plugins/catalyst/test_tuto_september_2025_ghost_attributes/main.c
Outdated
Show resolved
Hide resolved
plugins/catalyst/test_tuto_september_2025_ghost_attributes/CMakeLists.txt
Outdated
Show resolved
Hide resolved
plugins/catalyst/test_tuto_september_2025_ghost_attributes/run_test.py
Outdated
Show resolved
Hide resolved
e8cfd88 to
8d46e43
Compare
benoitmartin88
left a comment
There was a problem hiding this comment.
Thank you for this contribution.
I think a little refactoring is needed.
| [submodule "vendor/catalyst-2.0.0"] | ||
| path = vendor/catalyst-2.0.0 | ||
| url = https://gitlab.kitware.com/paraview/catalyst |
There was a problem hiding this comment.
Shall we save a specific version of catalyst2 inside vendor for EMBEDDED use? As all other libs.
There was a problem hiding this comment.
Yes, we probably should vendor catalyst2. Could you add it ?
a405fad to
5c0fc8a
Compare
Add the catalyst plugin developed by Kitware as an official PDI plugin.
The plugin code have been copied in the branch and the catalyst library dependency is added as a submodule for easy update in the future.
When built with
BUILD_TESTINGCMake variable, the pdi-catalyst-plugin tests should pass:Looks like lots of boxes below are not checked. I'll update everything after PDI's team code review.
François
List of things to check before making a PR
Before merging your code, please check the following:
.clang-format;Fix #issuekeyword to autoclose the issue when merged.