Open
Conversation
Contributor
|
This is a really useful addition. @pb- any plans of merging this? |
Contributor
Author
|
@pb- I am so excited to see there have been more pull requests since I worked on this a few years ago! Do you think we could merge this pull request? |
Contributor
Author
|
I just rebased on top of master. I'm not fully sure what to do about how the actual / expected looks. Input appreciated. |
Contributor
Author
|
@pb- How can we get this merged? What changes would you like to see? |
Owner
|
@adamryman apologies for responding way too late, you probably already gave up on this. Just in case not - I'm wondering if the mismatch message (expected/actual) is supposed to go away after the penalty delay? It seems that it sticks around, which is a bit confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to see what key I hit by mistake.
Up to change implementation if desired, I am liking the result though.
Image of what it looks like in slow mode.