feat(CC-batch-5): added batch 5 - #11867
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11867.surge.sh A11y report: https://patternfly-react-pr-11867-a11y.surge.sh Preview: https://pf-react-pr-11867.surge.sh A11y report: https://pf-react-pr-11867-a11y.surge.sh |
mattnolting
marked this pull request as ready for review
June 12, 2025 11:57
nicolethoen
requested changes
Jun 12, 2025
kmcfaul
reviewed
Jun 12, 2025
mattnolting
marked this pull request as draft
June 17, 2025 14:53
mattnolting
marked this pull request as ready for review
June 24, 2025 15:22
mattnolting
force-pushed
the
feat-batch-5
branch
from
June 30, 2025 20:25
f29dde6 to
7b1421c
Compare
mattnolting
force-pushed
the
feat-batch-5
branch
2 times, most recently
from
July 29, 2025 18:19
2943ad5 to
1e06fac
Compare
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
| example: (props) => ( | ||
| <CalendarMonth | ||
| date={props.startDate} | ||
| inlineProps={inlineProps} |
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
| isOpen: figma.enum('State', { Open: true }) | ||
| }, | ||
| example: (props) => ( | ||
| <TimePicker isDisabled={props.isDisabled} isOpen={props.isOpen} onChange={() => {}} time="3:35 AM" /> |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| <TimePicker isDisabled={props.isDisabled} isOpen={props.isOpen} onChange={() => {}} time="3:35 AM" /> | |
| <TimePicker isDisabled={props.isDisabled} onChange={() => {}} time="3:35 AM" /> |
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
mattnolting
commented
Jul 29, 2025
Comment on lines
+54
to
+68
| <EmptyStateFooter> | ||
| <EmptyStateActions>{props.actions}</EmptyStateActions> | ||
| </EmptyStateFooter> |
Contributor
Author
There was a problem hiding this comment.
Statically render button set
mattnolting
force-pushed
the
feat-batch-5
branch
from
July 31, 2025 19:30
1e06fac to
0373c15
Compare
mattnolting
commented
Aug 12, 2025
mattnolting
commented
Aug 12, 2025
mattnolting
commented
Aug 12, 2025
mattnolting
commented
Aug 12, 2025
| browseButtonText="Upload" | ||
| isLoading={props.isLoading} | ||
| validated={props.isValidated} | ||
| isDragActive={props.isDragActive} |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| isDragActive={props.isDragActive} |
mattnolting
commented
Aug 12, 2025
mattnolting
commented
Aug 12, 2025
| isOpen={false} | ||
| onSelect={() => {}} | ||
| onOpenChange={() => {}} | ||
| toggle={() => ( |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| toggle={() => ( | |
| toggle={(toggleRef) => ( |
mattnolting
commented
Aug 12, 2025
mattnolting
force-pushed
the
feat-batch-5
branch
from
August 14, 2025 14:31
0373c15 to
02a3244
Compare
mattnolting
force-pushed
the
feat-batch-5
branch
from
August 26, 2025 01:37
1efa3d4 to
5c1c4b4
Compare
kmcfaul
approved these changes
Aug 26, 2025
nicolethoen
approved these changes
Aug 26, 2025
mattnolting
force-pushed
the
feat-batch-5
branch
from
August 29, 2025 15:35
da26cb8 to
6fc3807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: