refactor(server): parsepackagestring called on potentially undefined packagequery#974
Open
LucciHank wants to merge 1 commit intopastelsky:bundlephobiafrom
Conversation
…uery ctx.query.package can be undefined (missing query param). Passing it to parsePackageString does `packageString.lastIndexOf` which throws TypeError. The line is outside any try/catch and after the build, so the whole request fails. Identical code exists in exports.middleware.js. Affected files: exportsSizes.middleware.js Signed-off-by: Hoangg Anh <131897682+LucciHank@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ctx.query.package can be undefined (missing query param). Passing it to parsePackageString does
packageString.lastIndexOfwhich throws TypeError. The line is outside any try/catch and after the build, so the whole request fails. Identical code exists in exports.middleware.js.Changes
server/middlewares/exportsSizes.middleware.js(modified)Type of Change
Testing
Severity:
highContributed by Lê Thành Chỉnh
Code is a tool. Mindset is the real value.
Closes #973