refactor(utils): parsepackagestring crashes on undefined packagestring#972
Open
LucciHank wants to merge 1 commit intopastelsky:bundlephobiafrom
Conversation
When ctx.query.package is absent, packageQuery is undefined. Calling parsePackageString(undefined) does `undefined.lastIndexOf` which throws TypeError. This crashes the exports/exportSizes middleware on any request missing the package query param (or malformed requests), taking down the response. Affected files: common.utils.js Signed-off-by: Hoangg Anh <131897682+LucciHank@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When ctx.query.package is absent, packageQuery is undefined. Calling parsePackageString(undefined) does
undefined.lastIndexOfwhich throws TypeError. This crashes the exports/exportSizes middleware on any request missing the package query param (or malformed requests), taking down the response.Changes
utils/common.utils.js(modified)Type of Change
Testing
Severity:
highContributed by Lê Thành Chỉnh
Code is a tool. Mindset is the real value.
Closes #971