Open
Conversation
- name parameters after packages - use constant_d instead of just d - add caching (from pastas caching simulate branch) - do not add stressmodel to model in ModflowModel class - use initialize_model() to write packages - use update_model() to update parameters in packages (do not write pkg again, just update values) - separate method for updating timeseries packages (this should be replaced by overwriting the time series file prior to the solution loop once the api supports it)
- add update_parameters method - store API parameter_addresses and model name once gwf model is known - set param name to pkg, but set name column to name of stressmodel - use constant_d - RCH pkg: add compute_recharge method, add option to use_timeseries for testing, add update_timeseries method - only DIS, IC, STO, GHB, and RCH updated.
- manages parameters and API addresses for modifying values in API loop - implemented for most classes, but addresses still missing for UZF and compound classes with multiple packages probably don't work and have not been properly tested. - make ModflowModelApi inherit from ModflowModel
dbrakenhoff
commented
Nov 14, 2025
| api.set_model_name("my_model") | ||
| api.add_parameters("SS", "SY") | ||
| ss_address = api["SS"] # returns "MY_MODEL/STO/SS" | ||
| api.set_value(mf6, "SS", np.array([1e3])) |
Member
Author
There was a problem hiding this comment.
Rather large value for storage 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages and #34