Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Feb 16, 2025

Pull Request

Issue

Replaces type check. See reason parse-community/parse-server#9581

Closes: #2435

Approach

Uses eslint-plugin-expect-type for type checking

dtslint only allowed for 1 file but with this change we can have individual test files for every typescript file.

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (656e737) to head (c229c30).
Report is 13 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6256           
  Branches      1476      1451   -25     
=========================================
  Hits          6256      6256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis
Copy link
Member Author

dplewis commented Feb 17, 2025

@mtrezza @dblythy

285 problems (285 errors, 0 warnings)

@dplewis dplewis requested a review from a team February 17, 2025 00:02
mtrezza
mtrezza previously approved these changes Feb 17, 2025
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one; so should this be disabled in the CI for now, or how should we go about it to keep the CI green.

@dplewis
Copy link
Member Author

dplewis commented Feb 17, 2025

@mtrezza I supressed the error it should be good now.

@dplewis dplewis requested a review from mtrezza February 17, 2025 01:06
@mtrezza mtrezza merged commit fcc1010 into parse-community:alpha Feb 17, 2025
12 checks passed
@dplewis dplewis deleted the remove-dtslint branch February 18, 2025 04:54
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants