[WIP] Add block justification support#309
Draft
jakehemmerle wants to merge 2 commits intoparitytech:masterfrom
Draft
[WIP] Add block justification support#309jakehemmerle wants to merge 2 commits intoparitytech:masterfrom
jakehemmerle wants to merge 2 commits intoparitytech:masterfrom
Conversation
insipx
reviewed
Jun 28, 2021
Contributor
There was a problem hiding this comment.
looks good! Some small nits. Hopefully the SQLx bug gets fixed sooner rather than later :).
As for testing, there is a way. You can look here:
for how I testedblocks_paginated query, etc.
It's relatively new code with some of the recent PR's, so open to suggestions, but you can see/use the setup_data_scheme for an example of populating the SQL database with the 10,000 blocks. Also good to keep in mind that the 10,000 blocks start from block height 3,000,000. Those blocks are accessed from the test_common crate:
setup_data_scheme already inserts a bunch of blocks into SQL, so a good test might just be running that and then checking if the expected justifications exist 👍
substrate-archive/src/migrations/20210611075511_add_column_justification.sql
Outdated
Show resolved
Hide resolved
substrate-archive/src/migrations/20210611075511_add_column_justification.sql
Outdated
Show resolved
Hide resolved
6204416 to
cee4815
Compare
Co-authored-by: Andrew Plaza <aplaza@liquidthink.net>
cee4815 to
e4c6bda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waiting on a blocking sqlx bug mentioned in #147, should close #147 when this is merged
In the meantime, can you let me know if the next steps sound right?:
sqlx prepareto generate proper sqlx-data.json (this is blocking bug)