Skip to content

Conversation

@maxbrunet
Copy link
Member

Clean up bits extracted from #1412 that should make it in main anyway

  • Use BLUEBOX_VERSION variable in GH workflows
  • Move back to golangci-lint pre-commit hook with overwritten entry
  • Fix golangci-lint pre-commit hook by ensuring the BPF program file "exists" when linting (//nolint:typecheck on it does not work :/)
  • Remove unused 3rdparty/include/stdarg.h file (BPF_HEADERS is overwritten in bpf/Makefile at L52)
  • Remove mentions of libbpf.a in BPF program build, it is not needed
  • Remove unused import of embed (a copy/paste I guess)

@maxbrunet maxbrunet requested a review from a team as a code owner March 6, 2023 20:33
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ 💚 💙 💛 💜

@kakkoyun kakkoyun merged commit 68ecbac into parca-dev:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants