Add XFA support to AcroForm module #3909
Open
+247
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDziurlaj
reviewed
Oct 26, 2025
src/modules/acroform.js
Outdated
| " R" | ||
| ); | ||
| if (scope.internal.acroformPlugin.needRendering === true) { | ||
| scope.internal.write("/NeedRendering true"); |
There was a problem hiding this comment.
Should be NeedsRendering (plural). Check and fix throughout PR.
There was a problem hiding this comment.
Thanks for catching that! I’ve updated the code/tests to use /NeedsRendering and pushed the change.
dsolankii
force-pushed
the
feature/add-xfa-support
branch
from
8b46a68 to
58511ce
Compare
HackbrettXXX
requested changes
Oct 28, 2025
| internal: null, | ||
| isInitialized: false | ||
| isInitialized: false, | ||
| needRendering: false |
There was a problem hiding this comment.
I think we should also rename this field to "needsRendering"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
addXFAentry point to embed XFA payloads and toggle NeedRenderingTesting
Closes #3886
(Friendly note: I’m participating in Hacktoberfest—thanks for tagging or merging!)