CLN: remove redundant type check in test_na_values_scalar #63122
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Nov 16, 2025
Member
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
pre-commit is failing. If you haven't set this up locally, it might be a good idea: https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit
Member
|
The diff here looks off; I think merging main will straighten it out. |
rustamali9183
force-pushed
the
fix-na-values-pyarrow
branch
from
60d3e47 to
208b197
Compare
rhshadrach
added
Testing
Member
|
Thanks @rustamali9183 |
Contributor
Author
Thanks @rhshadrach |
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR changes?
This PR cleans up a redundant nested
isinstance(na_values, dict)check intest_na_values_scalerfor the"pyarrow"engine.The inner check was always true and the
elsebranch was unreachable.Behavior after this PR
parser.engine == "pyarrow"andna_valuesis a dict:ValueErroris still expected.parser.engine == "pyarrow"andna_valuesis invalid (non-string types):TypeErroris still expected.Issue reference
Closes #63119
Checklist
233 passed, 1 skipped, 18 xfailed)