ENH: set __module__ on period_range #62645
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! This is one of my very first PRs, motivated by Hacktoberfest 2025. Although very simple in nature, I hope it meets the repo's standards. If not, I will be more than happy to learn and improve. |
|
LGTM. pls merge main and ping on green |
|
In addition, you have a small styling issue which makes the pre-commit check fail. See https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#pre-commit for how to resolve this (personally I would recommend installing and enabling pre-commit, so this gets always done automatically and you don't have to think about it) |
15 tasks
|
All done. Merged main and ran pre-commit fixes. CI is green now. @jbrockmendel |
jorisvandenbossche
changed the title
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__module__on top-level public objects #55178doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This decorates period_range with @set_module('pandas'). Similar to #60264