-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
Expand data table representation #62362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand data table representation #62362
Conversation
|
All checks have passed and there are no merge conflicts. This PR is ready for review and merge. Please let me know if there are any further suggestions or changes needed. Thank you! |
|
hey, is there anyone!! |
|
hey @mroeschke @afeld , |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, apologies for the slow response here. A few things:
- Looks like some changes for #62314 were included — please remove, to keep this pull request focused.
- Let's try and match the style of the existing diagrams, for consistency. Specifically:
- Font — not sure what it is, off hand
- The different grey fills
-
01_table_dataframe.svgis used multiple places. Let's replace the existing file, for simplicity. - Please clean up the commit history, rebasing so there's just a single commit with the change.
Thanks!
|
Hey, actually, I missed that someone else had grabbed it, and has a pull request that's closer to ready: #62466 I appreciate your work on this! |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature. (Will add if requested)