Open
Conversation
Author
|
The remaining failures are all on Python 2.7 because it doesn't have the selectors module (and almost certainly other issues). It's all fixable if you really want, but there are a lot of little niceties in recent versions of Python, and we're a year past the end of life for 2.7 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2 (I hope :-), a race condition between changing the flag value and updating the operating system eventfd/pipe/socket. Rather than trying to always update them together using a lock, this drops the flag, and uses the operating system whenever we want to query or update the event state.
This also means that an EventFD object can be used reliably between processes - child processes will share the operating system state but they would each have their own
_flagvalue.Non-blocking FDs are used so it doesn't hang if multiple threads/processes try to set or clear the same event.