Skip to content

Use <footer> in place of <div>#91

Open
nisbet-hubbard wants to merge 1 commit into
pages-themes:masterfrom
nisbet-hubbard:patch-1
Open

Use <footer> in place of <div>#91
nisbet-hubbard wants to merge 1 commit into
pages-themes:masterfrom
nisbet-hubbard:patch-1

Conversation

@nisbet-hubbard

@nisbet-hubbard nisbet-hubbard commented Jul 2, 2024

Copy link
Copy Markdown

This is a low-hanging fruit. Semantic tags improve accessibility, and there’s no cosmetic change involved in this case.

A remaining issue is the duplicate <h1> tags: one from site name, and a second one from first-level heading:

    <div class="container-lg px-3 my-5 markdown-body">
      
      <h1><a href="https://pages-themes.github.io/primer/">Jekyll Theme Primer</a></h1>
      

      <p>Text can be <strong>bold</strong>, <em>italic</em>, or <del>strikethrough</del>.</p>

<p><a href="./another-page.html">Link to another page</a>.</p>

<p>There should be whitespace between paragraphs.</p>

<p>There should be whitespace between paragraphs. We recommend including a README, or a file with information about your project.</p>

<h1 id="header-1">Header 1</h1>

A good solution would be to enclose the first inside a <header> or <nav>, and {{ content }} inside a <main>, since it’s idiomatic for different sections to get their own <h1>.

Example from other themes: cotes2020/jekyll-theme-chirpy#1207.

@welcome

welcome Bot commented Jul 2, 2024

Copy link
Copy Markdown

Welcome! Congrats on your first pull request to the Primer theme. If you haven't already, please be sure to check out the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant