feat: add cmd+k hotkey to focus search bar with kbd badge indicator#47
Merged
feat: add cmd+k hotkey to focus search bar with kbd badge indicator#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tanstack/react-hotkeysand wraps the app withHotkeysProviderinmain.tsxMod+Khotkey (⌘Kon Mac,Ctrl+Kon Windows/Linux) that focuses the search input from anywhere on the page<kbd>badge on the right side of the search input showing the platform-appropriate shortcut hint; the badge fades out when the input is focused or has a queryTesting
5 new tests added to
SearchBar.test.tsx:renders the kbd badge when enabled<kbd>element is present in the DOM whenSearchBaris enabledkbd badge has hidden class when input is focusedsearch-bar-kbd--hiddenclass on focuskbd badge has hidden class when query is non-emptysearch-bar-kbd--hiddenclass when user has typedkbd badge does not have hidden class when input is blurred and query is emptyMod+K focuses the search inputCtrl+K(jsdom resolvesMod→Controlon Linux) movesdocument.activeElementto the inputAll 89 tests pass (
npm run lint && npm run test && npm run buildclean).