feat: allow links to have custom icons via url or emoji#44
Open
feat: allow links to have custom icons via url or emoji#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for custom link icons via URL or emoji, in addition to the default favicon behavior. Users can now choose between favicon (default), a custom icon URL, or an emoji icon for each link in the config editor.
Changes
src/types/config.ts— AddediconUrlandiconEmojioptional fields toLinkConfigsrc/screens/HomeScreen/components/iconDisplay.ts— New shared utility that resolves link icon display (emoji > iconUrl > icon > favicon)src/screens/HomeScreen/components/LinkItem.tsx— Updated to render emoji icons or image icons using the sharedgetIconDisplayutilitysrc/screens/HomeScreen/components/SearchBar.tsx— Updated search dropdown to show emoji icons alongside image faviconssrc/screens/HomeScreen/HomeScreen.tsx— Updated navigating state to show the correct custom icon (emoji or image)src/screens/ConfigEditorScreen/components/EmojiPicker.tsx— New emoji picker component with categorized emojis and searchsrc/screens/ConfigEditorScreen/components/LinksTab.tsx— Added icon type selector (Favicon/Icon URL/Emoji) per link with emoji picker integrationsrc/App.css— Added styles for emoji icons, emoji picker, and icon selector UI in config editorsrc/test/fixtures.ts— AddedmockLinkWithIconUrlandmockLinkWithEmojitest fixturessrc/screens/HomeScreen/components/LinkItem.test.tsx— Added tests for iconUrl, iconEmoji rendering, and priority orderingIssue Reference
Closes #42
Testing
All tests pass (87 tests across 11 test files). Lint and build succeed.
Verification
npm run lint && npm run test && npm run buildto verify all checks passThis PR was automatically generated by an AI agent (Claude Code). Please review carefully before merging.