Optimize _load()#73
Open
MrGallo wants to merge 1 commit intop5py:masterfrom
MrGallo:optimize-load-render-time
Open
Optimize _load()#73MrGallo wants to merge 1 commit intop5py:masterfrom MrGallo:optimize-load-render-time
MrGallo wants to merge 1 commit intop5py:masterfrom
MrGallo:optimize-load-render-time
Conversation
numyp.array() can simply take self.img to drastically reduce the computing time (~90%). 350ms to 24ms on my computer.
`renderer.render_image()` still takes 24ms when calling `text("hello", (50, 50))`. 13ms for the `gloo.Program.draw()` function in that same `render_image` function line #263.
Partially resolves #69
|
@MrGallo Looks good, please clean up tests and we'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numyp.array()can simply takeself._imgto drastically reduce the computing time (~90%). 350ms to 24ms on my computer.The whole
render_image()function insketch/render.pytakes a total of 24ms when callingtext("hello", (50, 50)). The call togloo.Program.draw()in that function takes 13ms (renderer.py line #263).Partially resolves #69