Warn for CYRILLIC, unknown #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
pr_misc_fixups_for_2_nov
branch
2 times, most recently
from
ed5e729 to
4a1e87b
Compare
Owner
|
I don't mind cosmetic PRs, although some of the changes I don't agree with, but not merged with real fixes putting off rebasing this to remove them is what has delayed merging ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow builds not using HD44780 that happen to have weird
DISPLAY_CHARSET_HD44780values to pass.Also suppress deprecated
sprintfwarnings to usesnprintfthat should instead be warning us to use Rust.