feat: make fsync configurable via fraction config#417
Open
honeynil wants to merge 1 commit intoozontech:mainfrom
Open
feat: make fsync configurable via fraction config#417honeynil wants to merge 1 commit intoozontech:mainfrom
honeynil wants to merge 1 commit intoozontech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199
Added
SkipFsync booltofrac.Configandcommon.SealParams.So fsync can be disabled at the fraction level, not just globally via
resources.skip_fsync.Useful in unit tests — setting
frac.Config{SkipFsync: true}cuts test time roughly in half when running hundreds of tests. Globalresources.skip_fsyncstill works and now propagates into fraction config automatically on startup.Model: -
Prompt: -