image: Add MBIST-enabled Cosmo images for mfg #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
helios-buildwith some changes that rely on oxidecomputer/amd-host-image-builder#255 & oxidecomputer/amd-host-image-builder#256 to allow for generating an image from a patch. As well as allowing for gating image generation on a feature flag (-F).With that, this introduces a pair of MBIST-enabled ROM images for Cosmo (
cosmo-mbist&cosmo-mbist-noaggr) to be generated alongside the usualcosmo.rom(oxidecomputer/hardware-cosmo#33) (gated behind featurembist). The-noaggrvariant should run ~5min quicker. Both images pull inoxidecomputer/dmar-reportto be available at/usr/bin/dmar-report. Once MBIST has completed and the OS has booted it can be used to collect the margining results in tarball to be further processed & analyzed (e.g. with dmar_tar2csv.py).