Skip to content

softnpu: fix router v6 keyset data #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

softnpu: fix router v6 keyset data #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion asic/src/softnpu/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ fn keyset_data(match_data: Vec<MatchEntryField>, table: &str) -> Vec<u8> {
keyset_data.extend_from_slice(&data[..4]);
}
RESOLVER_V6 => {
// "nexthop_ipv4" => bit<128>
// "nexthop_ipv6" => bit<128>
let mut buf = Vec::new();
serialize_value_type(&x, &mut buf);
buf.reverse();
Expand All @@ -564,6 +564,11 @@ fn keyset_data(match_data: Vec<MatchEntryField>, table: &str) -> Vec<u8> {
serialize_value_type(&x, &mut data);
keyset_data.extend_from_slice(&data[..2]);
}
ROUTER_V6_RT => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. How did I get this up on a4x2 if ipv6 routing doesn't work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things break non-deterministically. See the comments here. Sometimes CI in that PR works, sometimes it does not. I'm not sure if this is the cause yet. Still trying to determine where the inconsistency is creeping in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the cause of the issue in oxidecomputer/maghemite#545. I can reproduce the issue with this patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause for the flaky behavior I was seeing in CI has been identified. This was due to restarting dpd while keeping underlying state around in softnpu. The following ticket has been filed for this.

And until that gets done oxidecomputer/maghemite#545 is not restarting dendrite during its test runs.

// "idx" => exact => bit<16>
serialize_value_type(&x, &mut data);
keyset_data.extend_from_slice(&data[..2]);
}
NAT_V4 => {
// "dst_addr" => hdr.ipv4.dst: exact => bit<32>
serialize_value_type(&x, &mut data);
Expand Down