feature/enable vulkan raytracing extensions #1827
Conversation
|
Change looks good but what happens if the user does not have a device that supports raytracing ? will it just safely ignore the changes? |
YunmaoLeo
force-pushed
the
feat/patch_for_raytracing
branch
3 times, most recently
from
9b7c6a1 to
858107b
Compare
YunmaoLeo
force-pushed
the
feat/patch_for_raytracing
branch
from
858107b to
7962fb8
Compare
Yes it will be safe. According to Qt documententation, it is safe to add deviceExtensions even if the physical device might not support them.
Also, I've moved the code for creating the vulkan device and enabling raytracing extensions to |
|
thanks! will take some time to review it today |
| return g_staticVulkanInstance; | ||
| } | ||
|
|
||
| // Returns true if the device supports ray tracing |
There was a problem hiding this comment.
All the vulkan code should be in the
#if defined(QT_FEATURE_vulkan) && QT_CONFIG(vulkan) && __has_include(<vulkan/vulkan.h>)
guard as some platforms don't have vulkan
There was a problem hiding this comment.
I am not really sure, but I think all the vulkan related code here is fully wrapped in the guard.
Let me know if I missed anything, happy to adjust further.
src/lib/score/gfx/Vulkan.cpp
Outdated
| #include <score/gfx/Vulkan.hpp> | ||
|
|
||
| #if defined(QT_FEATURE_vulkan) && QT_CONFIG(vulkan) && __has_include(<vulkan/vulkan.h>) | ||
| #include "QRhiGles2.hpp" |
There was a problem hiding this comment.
I don't think this should go in here, and it should be with <qrhigles2.hpp> header formata
There was a problem hiding this comment.
Sorry, I've made a mistake here. I've changed it to correct header.
jcelerier
force-pushed
the
master
branch
4 times, most recently
from
a402674 to
c16c15a
Compare
2 participants
ScreenNode: add vulkan device extensions when initializing vulkan instances