Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joeljoby02
force-pushed
the
patch-refactor
branch
from
14ceb82 to
72171bc
Compare
|
|
||
| // Mount our own /patch route without auth that will use controller.patch | ||
| routeTester.use("/patch", [addAuth, controller.patchUpdate]) | ||
| routeTester.use("/patch", [limiter, addAuth, controller.patchUpdate]) |
| // Mount our own /create route without auth that will use controller.create | ||
| routeTester.use("/set", [addAuth, controller.patchSet]) | ||
| // Mount our own /set route without auth that will use controller.patchSet | ||
| routeTester.use("/set", [limiter, addAuth, controller.patchSet]) |
| // Mount our own /create route without auth that will use controller.create | ||
| routeTester.use("/unset", [addAuth, controller.patchUnset]) | ||
| // Mount our own /unset route without auth that will use controller.patchUnset | ||
| routeTester.use("/unset", [limiter, addAuth, controller.patchUnset]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored PATCH controllers to eliminate ~300 lines of duplicated code by creating a shared
patchBase.jsmodule that handles common logic for ID validation, database operations, and response formatting.Changes
patchBase.jswith consolidated PATCH operation logicpatchSet.js,patchUnset.js, andpatchUpdate.jsto use the base functiondb-controller.jsimports and fixed test syntax issues