Repository navigation
[3.x] Document that Node.js 26 requires osls v4 - #515
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osls v3 still uses the AWS SDK for JavaScript v2, which reads a response with one
read()perreadableevent. Node.js 26 changedread()to return one buffered chunk at a time (nodejs/node#60441), so there the SDK stalls on any response that arrives in more than one chunk, as reported in #514. That SDK is end-of-support and osls v4 no longer uses it, so this points Node.js 26 users to osls v4 in the README and the setup guide, leaving the declaredenginesrange as it is.