Creating Stable Ros Launch & Exit (Fortress Noetic)#1059
Open
Space-Swarm wants to merge 1 commit intoosrf:fortress-noeticfrom
Open
Creating Stable Ros Launch & Exit (Fortress Noetic)#1059Space-Swarm wants to merge 1 commit intoosrf:fortress-noeticfrom
Space-Swarm wants to merge 1 commit intoosrf:fortress-noeticfrom
Conversation
The way ros is currently launched leads to ros not shutting down properly when a node is shut down. Adding required = true to all ros nodes mean that they can be cleanly exited when one of the nodes is shut down. This ensures a stable setup to use on a repeated basis for trial runs using the SubT simulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way ros is currently launched leads to ros not shutting down properly when a node is shut down.
Adding required = true to all ros nodes mean that they can be cleanly exited when one of the nodes is shut down by calling the terminator node to end all ros nodes running. That means partial shutdowns are avoided after executing & ending a launch file and the code is more stable. This ensures a stable setup to use on a repeated basis for trial runs using the SubT simulator.