Fix ID comparison in osmium merge to match osmium sort behavior
#303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
osmium sort, object IDs are sorted according to the following rule:However, in
osmium merge, the order validation currently relies on a plain numerical comparison of IDs.As a result,
osmium mergemay fail when merging files produced byosmium sortif negative IDs are present.Proposed fix
This pull request addresses the mismatch by reusing the
id_ordercomparator defined inobject_comparisons.hpp.Specifically, it replaces the simple numeric comparison in
osmium mergewithid_order, ensuring consistency withosmium sort.