Skip to content

Add reconciler to manager concepts#1010

Open
jklare wants to merge 2 commits into
mainfrom
jk-add-reconciler
Open

Add reconciler to manager concepts#1010
jklare wants to merge 2 commits into
mainfrom
jk-add-reconciler

Conversation

@jklare

@jklare jklare commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 5 0 0 0.03s
✅ JSON jsonlint 4 0 0 0.08s
✅ JSON prettier 4 0 0 0.38s
✅ JSON v8r 4 0 0 8.73s
✅ MARKDOWN markdownlint 160 0 0 2.47s
✅ MARKDOWN markdown-table-formatter 160 0 0 0.41s
✅ REPOSITORY checkov yes no no 18.75s
✅ REPOSITORY git_diff yes no no 0.07s
✅ REPOSITORY secretlint yes no no 1.74s
✅ REPOSITORY trufflehog yes no no 3.92s
✅ SPELL codespell 170 0 0 0.44s
⚠️ SPELL lychee 170 1 0 20.79s
✅ YAML prettier 6 0 0 0.34s
✅ YAML v8r 6 0 0 6.32s
✅ YAML yamllint 6 0 0 0.41s

Detailed Issues

⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........926
🔗 Unique.........749
✅ Successful.....861
⏳ Timeouts.........3
🔀 Redirected......48
👻 Excluded........61
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in docs/appendix/security/ossa-2026-002.md
[TIMEOUT] https://bugs.launchpad.net/nova/+bug/2137507 (at 111:3) | Request timed out

Errors in docs/appendix/security/ossa-2026-015.md
[TIMEOUT] https://bugs.launchpad.net/keystone/+bug/2149775 (at 176:3) | Request timed out
[TIMEOUT] https://bugs.launchpad.net/keystone/+bug/2149789 (at 177:3) | Request timed out

Errors in docs/release-notes/index.md
[ERROR] https://release.osism.tech/ (at 11:1) | Connection failed. Check network connectivity and firewall settings

Hint: Followed 48 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_SECRETLINT,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,SPELL_CODESPELL,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depicts the inventory reconciler as an another ansible execution environment, where it is actually mostly python

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible is also mostly python :) To my understanding the trigger to start the "mostly python" you mention is still celery and an ansible playbook. Or?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible is also mostly python :)

I was expecting this comment, but still too lazy to elaborate :)

To my understanding the trigger to start the "mostly python" you mention is still celery and an ansible playbook. Or?

So, from my understanding there is a celery task which triggers a run.sh inside the inventory reconciler container. That run.sh is mostly triggering python scripts directly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so if I replace ansible with reconciler and drop playbooks/roles/collections from this container, the diagram would be correct?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arrow between reconciler and NetBox should also be bidirectional as the reconciler also writes stuff into the NetBox

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested. Please let me know if this is correct now.

@jklare jklare force-pushed the jk-add-reconciler branch 2 times, most recently from b27a4f4 to b22f52e Compare June 26, 2026 08:55
jklare added 2 commits June 26, 2026 16:38
* remove osism-kubernetes container from the diagram to make space for
  the inventory-reconciler since it just mirrors what osism-ansible,
  kolla-ansible and ceph-ansible already show

Signed-off-by: Jan Klare <klare@osism.tech>
* explicitly mention, that osism-kubernetes still exists and only was
  removed from the diagram to make space for the inventory-reconciler

AI-assisted: Claude Code
Signed-off-by: Jan Klare <klare@osism.tech>
@jklare jklare force-pushed the jk-add-reconciler branch from b22f52e to 20ecaa7 Compare June 26, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

3 participants