Select valkey over redis from 2025.2#368
Merged
Merged
Conversation
Upstream kolla-ansible replaced redis with valkey at stable/2025.2, so "osism apply redis" fails once the deployed image reaches 2025.2 while "valkey" is absent on 2025.1 and older. metalbox currently targets openstack_version 2024.2 (redis), so this is latent today, but the infra scripts must pick the service per release to stay correct as metalbox advances. Add a valkey_or_redis() helper in scripts/include.sh that reads the active OpenStack release from the kolla-ansible image label and echoes "valkey" for 2025.2 and newer or "redis" for 2025.1/2024.x. The deploy, update and run-all scripts resolve it once into a key_value_store variable and apply/pull/upgrade that. The per-release CI image mirror lists (zuul/vars/container-images-*.yml) already match their release (redis for 2024.2/2025.1) and are left as is; a 2025.2 list with valkey belongs with the future 2025.2 enablement. No secrets change here: metalbox's kolla secrets carry no plaintext redis_master_password, and valkey_master_password comes from the release-versioned cfg-cookiecutter secrets when metalbox moves to 2025.2. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the OSISM-wide redis → valkey migration (upstream kolla-ansible
replaced redis with valkey at
stable/2025.2; the redis role/playbook is gone).Picks the key-value store per OpenStack release (redis for 2024.x/2025.1, valkey
for 2025.2 and newer) so
osism apply/upgradetargets the service the activeimage actually ships. On upgrade to 2025.2, the valkey role's upgrade tasks
migrate the redis data and remove the old redis containers automatically — no
manual teardown.
Draft: the OSISM defaults switch-over and these consumer-script changes must
land together, gated on the release
defaults_versionpin bump — held as draftuntil that coordinated landing.
Part of the redis → valkey migration (all must land together, gated on the
release
defaults_versionpin bump):🤖 Generated with Claude Code