inventory: add ironic-dnsmasq service group#601
Merged
Conversation
kolla-ansible stable/2025.2 ships an ironic-dnsmasq inventory group in ansible/inventory/multinode, but this inventory never gained it. The ironic role dereferences groups['ironic-dnsmasq'] unconditionally: it appears as "groups['ironic-dnsmasq'] | length > 0" in the ironic config.yml and precheck.yml when-conditions and in the ironic-http and ironic-tftp container config templates. These expressions are evaluated on every ironic deployment, before any enable check. When the referenced inventory group is absent, Ansible aborts with "'dict object' has no attribute 'ironic-dnsmasq'" (the "dict object" is the groups var). This breaks every ironic-enabled deployment; only setups that do not deploy ironic (e.g. the virtualized testbed) are unaffected. Add the group as a child of ironic, mirroring kolla-ansible stable/2025.2 ansible/inventory/multinode, which also places it there. This is the same class of fix as commit 62b6274 (neutron 2025.2 service groups). Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the
ironic-dnsmasqinventory group (child ofironic) toinventory/51-kolla, mirroring kolla-ansiblestable/2025.2ansible/inventory/multinode.Why
kolla-ansible
stable/2025.2ships anironic-dnsmasqgroup in itsmultinodeinventory, but this inventory never gained it. The ironic roledereferences
groups['ironic-dnsmasq']unconditionally — it appears asgroups['ironic-dnsmasq'] | length > 0in:ironic/tasks/config.yml(4×) andironic/tasks/precheck.ymlwhen:conditionsironic-http.json.j2andironic-tftp.json.j2container config templatesThese expressions are evaluated on every ironic deployment, before any
enable check. With the group undefined, Ansible aborts with:
(the "dict object" being the
groupsvar). This breaks every ironic-enableddeployment; only setups that do not deploy ironic (e.g. the virtualized
testbed) are unaffected.
Same class of fix as the neutron 2025.2 groups
This is the identical failure mode and remedy as the recent neutron change:
Validation
tox -e check(inventory sorting) passes with the group inserted inalphabetical order between
ironic-conductorandironic-http.🤖 Generated with Claude Code