Remove orphaned kolla service config#291
Merged
Merged
Conversation
Upstream kolla-ansible removed six OpenStack services and no longer defines them at any supported release (2024.1-2025.2): freezer, murano, sahara, solum, vitrage and skydive. Their OSISM config was left behind. Delete their enable flags (enable_freezer, enable_murano, enable_sahara, enable_solum, enable_vitrage, enable_skydive) and the horizon dashboard toggles for them (enable_horizon_freezer/murano/sahara/solum/vitrage) from all/099-kolla.yml, plus their dead image-definition blocks (<svc>_tag, <svc>_*_image/_tag) from all/002-images-kolla.yml. These are genuine orphans surfaced by the drift detector's kolla_enablement_orphan (enable flags) and kolla_orphan_config (companion/image vars) checks; none are OSISM inventions, and none of the removed vars are referenced anywhere else in the OSISM repos. The other orphans (senlin, ironic_pxe_uefi, outward_rabbitmq) are each a special case and are removed in separate follow-up commits. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
Upstream kolla-ansible removed the senlin clustering service; it is
absent from enable-defaults at every supported release (2024.1-2025.2).
Senlin gets its own commit because, unlike the simpler removals, it is
coupled and carries companion config: enable_horizon_senlin was defined
as "{{ enable_senlin | bool }}" (referencing enable_senlin, so the two
must go together), and 099-kolla.yml also held senlin endpoint companion
vars (senlin_internal_fqdn, senlin_external_fqdn, senlin_api_port,
senlin_api_listen_port, senlin_api_public_port).
Remove enable_senlin, enable_horizon_senlin and those five companion
vars from all/099-kolla.yml, and the senlin image-definition block from
all/002-images-kolla.yml. All removed vars were verified unreferenced
elsewhere in the OSISM repos. Surfaced by the kolla_enablement_orphan
and kolla_orphan_config drift checks.
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Roger Luethi <luethi@osism.tech>
Upstream kolla-ansible no longer defines enable_ironic_pxe_uefi in its enable-defaults at any supported release (2024.1-2025.2), so the OSISM flag is orphaned. This is a flag-not-feature special case, hence its own commit: ironic PXE/UEFI provisioning itself still exists in the ironic role at 2025.2 (e.g. ansible/roles/ironic/defaults/main.yml, enable_ironic_pxe_filter, ironic-dnsmasq.conf.j2). Only this specific toggle was dropped upstream; the capability lives on under different variables. The flag has no companion or image-definition vars, so only the single line is removed from all/099-kolla.yml. Surfaced by the kolla_enablement_orphan drift check. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
Remove the whole outward_rabbitmq block from all/099-kolla.yml: the
enable flag enable_outward_rabbitmq plus its three companion vars
(outward_rabbitmq_external_fqdn, outward_rabbitmq_management_port,
outward_rabbitmq_port).
outward_rabbitmq is an OSISM-specific second ("outward") RabbitMQ
deployed by OSISM wrapper playbooks on kolla-ansible's generic rabbitmq
role. enable_outward_rabbitmq is absent from upstream kolla-ansible
group_vars at all four supported refs (a genuine orphan), and OSISM
dropped its outward_rabbitmq playbooks at 2025.1 (only the 2023.2/2024.1/
2024.2 playbooks still reference it). Removing the enable flag is safe:
the playbooks derive the tag via "enable_outward_rabbitmq |
default('false') | bool" (guarded), so default deploys are unaffected.
Known consequence: the 2024.1/2024.2 kolla-rabbitmq playbooks reference
outward_rabbitmq_management_port and outward_rabbitmq_port without a
default, so an operator who opts into outward_rabbitmq on those older
releases must now set those two ports in their own site config (they
already supply the other six outward_rabbitmq_* vars from secrets).
Fully retiring the feature from the 2024.x playbooks is left as a
separate follow-up. Surfaced by kolla_enablement_orphan (the flag) and
kolla_orphan_config (the companions).
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Roger Luethi <luethi@osism.tech>
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove OSISM config for OpenStack services that upstream kolla-ansible
has removed and no longer defines at any supported release
(2024.1–2025.2). The config was left behind when the services went away.
Removed across
all/099-kolla.ymlandall/002-images-kolla.yml:freezer,murano,sahara,solum,vitrage,skydive: theirenable_*flags, theenable_horizon_*dashboard toggles, and their image-definition blocks.
enable_senlin+ the coupledenable_horizon_senlin(defined as
"{{ enable_senlin | bool }}"), its endpoint companion vars(
senlin_internal_fqdn,senlin_external_fqdn,senlin_api_port,senlin_api_listen_port,senlin_api_public_port) and its image block.enable_ironic_pxe_uefiflag;the PXE/UEFI capability itself still exists in the ironic role under
different variables.
enable_outward_rabbitmqplusoutward_rabbitmq_external_fqdn/_management_port/_port).Why
These are genuine orphans: each
enable_*flag is absent from upstreamkolla-ansible's enable-defaults across the whole supported release range,
and the companion/image vars only existed to serve those dead services.
None are OSISM inventions, and none of the removed vars are referenced
elsewhere in the OSISM repos (verified). Surfaced by the image-drift
detector's
kolla_enablement_orphan(enable flags) andkolla_orphan_config(companion/image vars) checks. Split into one commitper concern for review.
Note
The 2024.1/2024.2
kolla-rabbitmqplaybooks still referenceoutward_rabbitmq_management_port/_portwithout a default. Defaultdeploys are unaffected (the enable tag is
default('false')-guarded), butan operator opting into outward_rabbitmq on those older releases must now
set those two ports in site config (alongside the other outward_rabbitmq
secrets they already supply). Fully retiring the feature from the 2024.x
playbooks is a separate follow-up.
🤖 Generated with Claude Code