zuul: drop redundant image-push post jobs#288
Merged
Conversation
The two post-pipeline jobs that rebuild and push the osism-ansible and inventory-reconciler container images are redundant: the image Dockerfiles git checkout a fixed tag pinned in osism/release, not defaults main, so a post-on-main rebuild bakes in the pinned tag rather than the triggering commit. The real :latest refresh comes from the image repos' own post jobs and their nightly periodic builds, which these jobs merely duplicated. Unlike the equivalent jobs in osism/generics, these still run (defaults was never renamed, so SECRET_DEFAULTS decrypts), but they do the same busywork on every merge to main for no reliable benefit. Remove the two job definitions, their post: pipeline entries, and the now-unused SECRET_DEFAULTS secret. Nothing else references the secret. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the two post-pipeline image-push jobs
(
defaults-container-image-{inventory-reconciler,osism-ansible}-push),their
post:pipeline entries, and the now-unusedSECRET_DEFAULTSsecret.
These jobs run on every merge to
mainbut are redundant: the imageDockerfiles
git checkouta fixed tag pinned inosism/release, notdefaults
main, so a post-on-main rebuild bakes in the pinned tagrather than the triggering commit. The real
:latestrefresh comesfrom the image repos' own post jobs and their nightly periodic builds,
which these jobs merely duplicated.
Context
This is the parity cleanup to the equivalent change in
osism/generics:The difference: in generics the same jobs had additionally been failing
with
RETRY_LIMITsince thecfg-generics→genericsrenameinvalidated its secret. defaults was never renamed, so
SECRET_DEFAULTSstill decrypts and these jobs succeed — they just do redundant
busywork. No active breakage here; this removes the duplicated work and
keeps the two config repos consistent.
Verification
.zuul.yamlparses and passesyamllint.zuul-config/zuul-jobsreferences the removedjobs or the secret.
🤖 Generated with Claude Code