kolla: use docker_image_url variable for image definitions#285
Merged
Conversation
Stop repeating the registry/namespace prefix for every kolla image by introducing the docker_image_url variable and using it in 002-images-kolla.yml, mirroring upstream kolla-ansible commit 0a07462d1d9d5e9ea800ccf85f058dbd47980add. docker_image_url is defined in 001-kolla-defaults.yml and resolves via docker_registry_kolla, so the rendered image URLs stay identical. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop repeating the registry/namespace prefix for every kolla image by introducing the
docker_image_urlvariable and using it throughoutall/002-images-kolla.yml.This mirrors upstream kolla-ansible commit
0a07462("Stop repeating the same code").Changes
all/001-kolla-defaults.yml: definedocker_image_url(resolves viadocker_registry_kolla).all/002-images-kolla.yml: replace all 203 occurrences of{{ docker_registry_kolla }}/{{ docker_namespace }}/…with{{ docker_image_url }}….Notes
docker_image_urlresolves throughdocker_registry_kolla(registry.osism.tech) anddocker_namespace(kolla).dcap_*_image_fullentries keep their…|default(…)pattern and are left unchanged.yaml.safe_loadandyamllint.🤖 Generated with Claude Code