ceph: add ceph_require_min_compat_client default variable#284
Merged
Conversation
This was referenced May 24, 2026
Merged
berendt
requested changes
May 26, 2026
Add two variables to the new cluster policy section of all/099-ceph.yml: ceph_require_min_compat_client (default: mimic) — passed to `ceph osd set-require-min-compat-client` by container-image-ceph-ansible during the ceph-pools lifecycle step. With mimic or newer, RBD clone v2 is enabled cluster-wide: parent snapshots no longer need to be protected for clones to reference them, which allows Glance to delete images that have active Nova ephemeral disk clones (HTTP 409 fix). Set to '' to skip; see operator documentation for side effects on production clusters (client lockout, Ceph trash semantics, one-way change). ceph_min_compat_client_order — integer ordering map for release names, used by container-image-ceph-ansible for the idempotency check: the minimum is only raised, never lowered. Extend when new Ceph releases are supported. AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
311b9ce to
d0366ee
Compare
ideaship
added a commit
to osism/testbed
that referenced
this pull request
May 26, 2026
Reverts commit 621a279 (PR #2885), which excluded both ImageDependencyTests as a workaround for the HTTP 409 failure caused by the Glance/Ceph RBD clone v1 incompatibility. The root cause is fixed by: - osism/defaults#284 — adds ceph_require_min_compat_client default - osism/container-image-ceph-ansible#690 — applies it via ceph-pools Merge this commit after both of the above are in. Related: #2884 AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
berendt
pushed a commit
to osism/testbed
that referenced
this pull request
May 29, 2026
Reverts commit 621a279 (PR #2885), which excluded both ImageDependencyTests as a workaround for the HTTP 409 failure caused by the Glance/Ceph RBD clone v1 incompatibility. The root cause is fixed by: - osism/defaults#284 — adds ceph_require_min_compat_client default - osism/container-image-ceph-ansible#690 — applies it via ceph-pools Merge this commit after both of the above are in. Related: #2884 AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ceph_require_min_compat_client(default:mimic) toall/099-ceph.ymlunder a new# cluster policysectionceph_min_compat_client_order— an integer ordering map of Ceph release names used bycontainer-image-ceph-ansiblefor the idempotency check (only raise, never lower)The variable is consumed by
container-image-ceph-ansibleduring theceph-poolslifecycle step to runceph osd set-require-min-compat-client. Withmimicor newer, RBD clone v2 is enabled cluster-wide: parent snapshots no longer need to be protected, so Glance can delete images that have active Nova ephemeral disk clones (fixes HTTP 409).See
osism/container-image-ceph-ansiblefor the companion PR that reads this variable and applies it.Side effects of raising require-min-compat-client to mimic (documented in the variable's comment):
Set to
''to skip if the cluster must remain at luminous compat level.Test plan
container-image-ceph-ansibletested end-to-end in bedbox: bothImageDependencyTestspassexclude.lstentries (testbed PR #2885) reverted once the full fix is confirmed in CI🤖 Generated with Claude Code