Skip to content

Initial setup and environment verification for Osdag#431

Merged
parthckaria merged 12 commits intoosdag-admin:devfrom
MohammedSharukkhanM:intern-khans-work
Mar 30, 2026
Merged

Initial setup and environment verification for Osdag#431
parthckaria merged 12 commits intoosdag-admin:devfrom
MohammedSharukkhanM:intern-khans-work

Conversation

@MohammedSharukkhanM
Copy link
Copy Markdown

  • Forked the Osdag repository.
  • Successfully set up the Conda environment (osdag-env) on Arch Linux.
  • Verified the local development workflow by adding a setup report.
  • Ready to begin assigned tasks.

@MohammedSharukkhanM
Copy link
Copy Markdown
Author

I have updated the GUI labels in 4 files as assigned. Please review the changes.

… now Primary Beam and Beam is now Secondary Beam Standardize hover labels and rename Cover Plate to Splice Plate for Column Splice modules
@MohammedSharukkhanM
Copy link
Copy Markdown
Author

I have updated this PR with the hover-over implementation for the Cleat Angle module. It now shows the Beam, Column, Angle, and Bolt details in the 3D viewer.

@AjinkyaDahale please review these latest changes.

Comment thread src/osdag/gui/ui_template.py Outdated

# Set the vertical header labels
vertical_labels = ["Bolt Details", "Dia. of Bolt(mm)", "Property Class", "Bolt Hole Dia.(mm)", "No. of Bolts(nos)", "Bolt Rows(nos)", "Bolt Columns(nos)", "End Distance(mm)", "Pitch Distance(mm)", "Edge Distance_1(mm)", "Gauge Distance(mm)", "Edge Distance_2(mm)", "Overlap Length(mm)", "Bolt Strength Detail", "Single Bolt Capacity(KN)", "Bolt Group Capacity(KN)", "Factored Laod(KN)", "Capacity Factor(KN)"]
vertical_labels = ["Bolt Details", "Dia. of Bolt(mm)", "Property Class", "Bolt Hole Dia.(mm)", "No. of Bolts(no)", "Bolt Rows(no)", "Bolt Columns(no)", "End Distance(mm)", "Pitch Distance(mm)", "Edge Distance_1(mm)", "Gauge Distance(mm)", "Edge Distance_2(mm)", "Overlap Length(mm)", "Bolt Strength Detail", "Single Bolt Capacity(KN)", "Bolt Group Capacity(KN)", "Factored Laod(KN)", "Capacity Factor(KN)"]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use KEY_DISP etc. here? Also, shouldn't there be a space before the brackets in each string @parthckaria ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.hover_dict["Conc"] = (
f"<b>Concrete Pedestal</b><br>"
f"Grade: {self.footing_grade if flag else ''} mm<br>"
# f"Grade: {self.footing_grade if flag else ''} mm<br>"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't leave as comment. delete or add additional text as to why this must be here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +912 to +913
# f"Length: {self.bp_length_provided * 1.5 if flag else ''} mm<br>"
# f"Width: {self.bp_width_provided * 1.5 if flag else ''} mm<br>"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous, plus same is done everywhere else. Please delete lines instead of commenting.

@AjinkyaDahale
Copy link
Copy Markdown
Collaborator

@MohammedSharukkhanM please rebase and, in the process, delete the commented code that you added.

@MohammedSharukkhanM
Copy link
Copy Markdown
Author

As instructed unnecessary comment lines are deleted and space is added between the brackets and strings.

@AjinkyaDahale Please review these changes.

@parthckaria parthckaria merged commit 244b8b1 into osdag-admin:dev Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants