cockpit-image-builder: export blueprints (RHEL-123840) #3779
+456
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
force-pushed
the
cockpit-toml-export
branch
2 times, most recently
from
cc28ed9 to
6ab29ba
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3779 +/- ##
==========================================
- Coverage 81.00% 80.95% -0.05%
==========================================
Files 217 217
Lines 25079 25102 +23
Branches 2494 2496 +2
==========================================
+ Hits 20315 20322 +7
- Misses 4736 4752 +16
Partials 28 28
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
croissanne
force-pushed
the
cockpit-toml-export
branch
2 times, most recently
from
06c08e2 to
92d0be5
Compare
croissanne
commented
Oct 30, 2025
croissanne
commented
Oct 30, 2025
croissanne
force-pushed
the
cockpit-toml-export
branch
from
92d0be5 to
c94e4b3
Compare
croissanne
changed the title
croissanne
force-pushed
the
cockpit-toml-export
branch
2 times, most recently
from
16c1ba9 to
fc8fbb2
Compare
Export the blueprint as TOML on premise, and not as JSON. The expectation is that users might want to use this blueprint with composer-cli or image-builder-cli. Because the behaviour is different between the cockpit and hosted UIs, refrain from making the backend api abstraction.
croissanne
force-pushed
the
cockpit-toml-export
branch
from
fc8fbb2 to
fc64d5a
Compare
Also verify the contents of the exported blueprint. For hosted this is not important as there the exported blueprint is just forwarded from image-builder-crc. But in cockpit-image-builder all blueprint management is handled inside of the plugin itself, thus it is important to verify the contents of the export.
croissanne
force-pushed
the
cockpit-toml-export
branch
from
fc64d5a to
b1f1940
Compare
|
/retest |
mgold1234
reviewed
Nov 3, 2025
There was a problem hiding this comment.
@croissanne it looks great, I left 2 small suggestion, other then that it looks good to me
| import { EllipsisVIcon } from '@patternfly/react-icons'; | ||
| import TOML from 'smol-toml'; | ||
|
|
||
| // The exported contents are different between hosted and on prem, so |
There was a problem hiding this comment.
what do you think maybe write it little different?
// The hosted UI exports JSON, while the Cockpit plugin exports TOML.
// Because the blueprint formats are not aligned, relying on a generic 'backendApi'
// would be misleading. Import and handle each environment explicitly.
| // and on prem, so just import both separately. | ||
| import { selectSelectedBlueprintId } from '../../store/BlueprintSlice'; | ||
| import { useLazyExportBlueprintCockpitQuery } from '../../store/cockpit/cockpitApi'; | ||
| import type { Blueprint as CloudApiBlueprint } from '../../store/cockpit/composerCloudApi'; |
There was a problem hiding this comment.
it is litte confusing to use CloudApi and also cockpit -
maybe 'cockpitExportResponse' instead of CloudApiBlueprint'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.