Skip to content

Comments

feat: add ChatGPT support#94

Draft
baruchiro wants to merge 17 commits intoos-scar:masterfrom
Checkmarx:86-implement-on-chatgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion
Draft

feat: add ChatGPT support#94
baruchiro wants to merge 17 commits intoos-scar:masterfrom
Checkmarx:86-implement-on-chatgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion

Conversation

@baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Jun 4, 2023

  • move finder code to share with all content
  • rename indicator.js -> create-element.js
  • move element creation to create-element
  • inject contentElementSelector
  • include the self element in findRanges
  • add the content.chatgpt to build

Part of #86

Need help with the style:
image

@baruchiro baruchiro linked an issue Jun 4, 2023 that may be closed by this pull request
…tgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion
@baruchiro baruchiro requested review from GuyNachshon and jossef and removed request for jossef June 4, 2023 12:14
@GuyNachshon
Copy link
Collaborator

it seems like we have two options to solve this:

  1. diverge the CSS when we are on chatgpt's URL to manipulate the color
  2. add a more comprehended solution traversing up to the first background colour and determining the colour based on it.

@baruchiro @jossef WDYT?

@baruchiro baruchiro added the UI label Jun 5, 2023
…these-needs-prompt-to-reproduce-a-package-suggestion
@baruchiro
Copy link
Collaborator Author

On Hold: Waiting for @jossef to finish the Figma styles and support dark mode.

@baruchiro baruchiro self-assigned this Jun 11, 2023
…hatgpt-bard-new-bing-all-these-needs-prompt-to-reproduce-a-package-suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants